summaryrefslogtreecommitdiffstats
path: root/firmware
diff options
context:
space:
mode:
authorJohannes Weiner <hannes@cmpxchg.org>2014-10-02 16:21:10 -0700
committerLinus Torvalds <torvalds@linux-foundation.org>2014-10-02 16:28:44 -0700
commitabe5f972912d086c080be4bde67750630b6fb38b (patch)
treea601d6b5a7cb3733492d7c1591df135b95c1f4bb /firmware
parent6c72e3501d0d62fc064d3680e5234f3463ec5a86 (diff)
downloadop-kernel-dev-abe5f972912d086c080be4bde67750630b6fb38b.zip
op-kernel-dev-abe5f972912d086c080be4bde67750630b6fb38b.tar.gz
mm: page_alloc: fix zone allocation fairness on UP
The zone allocation batches can easily underflow due to higher-order allocations or spills to remote nodes. On SMP that's fine, because underflows are expected from concurrency and dealt with by returning 0. But on UP, zone_page_state will just return a wrapped unsigned long, which will get past the <= 0 check and then consider the zone eligible until its watermarks are hit. Commit 3a025760fc15 ("mm: page_alloc: spill to remote nodes before waking kswapd") already made the counter-resetting use atomic_long_read() to accomodate underflows from remote spills, but it didn't go all the way with it. Make it clear that these batches are expected to go negative regardless of concurrency, and use atomic_long_read() everywhere. Fixes: 81c0a2bb515f ("mm: page_alloc: fair zone allocator policy") Reported-by: Vlastimil Babka <vbabka@suse.cz> Reported-by: Leon Romanovsky <leon@leon.nu> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org> Acked-by: Mel Gorman <mgorman@suse.de> Cc: <stable@vger.kernel.org> [3.12+] Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'firmware')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud