summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorRasmus Villemoes <linux@rasmusvillemoes.dk>2015-09-09 23:59:43 +0200
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>2015-09-15 02:59:07 +0200
commit6a0d12ef993c5291047d72e88d73d0aa2b967335 (patch)
tree5d75224e9b237a022f9d6131080c1f257909743a /drivers
parent844142c3f80c66fb2c311b118d60abdfe02322cb (diff)
downloadop-kernel-dev-6a0d12ef993c5291047d72e88d73d0aa2b967335.zip
op-kernel-dev-6a0d12ef993c5291047d72e88d73d0aa2b967335.tar.gz
ACPI / scan: use kstrdup_const() in acpi_add_id()
Empirically, acpi_add_id is mostly called with string literals, so using kstrdup_const for initializing struct acpi_hardware_id::id saves a little run-time memory and a string copy. Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/acpi/scan.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
index a3eaf20..afaac47 100644
--- a/drivers/acpi/scan.c
+++ b/drivers/acpi/scan.c
@@ -1184,7 +1184,7 @@ static void acpi_add_id(struct acpi_device_pnp *pnp, const char *dev_id)
if (!id)
return;
- id->id = kstrdup(dev_id, GFP_KERNEL);
+ id->id = kstrdup_const(dev_id, GFP_KERNEL);
if (!id->id) {
kfree(id);
return;
@@ -1322,7 +1322,7 @@ void acpi_free_pnp_ids(struct acpi_device_pnp *pnp)
struct acpi_hardware_id *id, *tmp;
list_for_each_entry_safe(id, tmp, &pnp->ids, list) {
- kfree(id->id);
+ kfree_const(id->id);
kfree(id);
}
kfree(pnp->unique_id);
OpenPOWER on IntegriCloud