summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorDan Carpenter <error27@gmail.com>2010-12-20 21:04:02 +0000
committerDavid S. Miller <davem@davemloft.net>2010-12-21 10:51:45 -0800
commit4b97f8e10893e2c8f64a2795901bdb447a3308f4 (patch)
treeca41864a34a0aa3702f38c8fd139aa1b4720cee2 /drivers
parent70978182d431e0348e6ef711d0f962d12c03bc46 (diff)
downloadop-kernel-dev-4b97f8e10893e2c8f64a2795901bdb447a3308f4.zip
op-kernel-dev-4b97f8e10893e2c8f64a2795901bdb447a3308f4.tar.gz
bnx2x: remove bogus check
We dereferenced params on the line before so it's too late to check if params is NULL. In fact, params can never be NULL and strict_cos is either 0 or 1 so that part of the check is bogus too. Let's remove it. Signed-off-by: Dan Carpenter <error27@gmail.com> Acked-by: Eilon Greenstein <eilong@broadcom.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/net/bnx2x/bnx2x_link.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/net/bnx2x/bnx2x_link.c b/drivers/net/bnx2x/bnx2x_link.c
index 97cbee2..43b0de2 100644
--- a/drivers/net/bnx2x/bnx2x_link.c
+++ b/drivers/net/bnx2x/bnx2x_link.c
@@ -354,9 +354,6 @@ u8 bnx2x_ets_strict(const struct link_params *params, const u8 strict_cos)
struct bnx2x *bp = params->bp;
u32 val = 0;
- if ((1 < strict_cos) && (NULL == params))
- return -EINVAL;
-
DP(NETIF_MSG_LINK, "ETS enabled strict configuration\n");
/**
* Bitmap of 5bits length. Each bit specifies whether the entry behaves
OpenPOWER on IntegriCloud