diff options
| author | Wang Chen <wangchen@cn.fujitsu.com> | 2008-09-26 16:20:32 +0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2008-10-08 16:02:40 -0700 |
| commit | e824b3eb4acad16c64c9ddf8e63b63e2469259b0 (patch) | |
| tree | e350547cda629039cdaa3d3995541985070eda64 /drivers | |
| parent | 9ac1353f3832716eb25268c0cd06c93080a83c7b (diff) | |
| download | op-kernel-dev-e824b3eb4acad16c64c9ddf8e63b63e2469259b0.zip op-kernel-dev-e824b3eb4acad16c64c9ddf8e63b63e2469259b0.tar.gz | |
skge: Fix skge_set_ring_param() losing error return
The error return is useful to caller, driver shouldn't miss it.
Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/skge.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/skge.c b/drivers/net/skge.c index 3bca52c..43f4c73 100644 --- a/drivers/net/skge.c +++ b/drivers/net/skge.c @@ -501,7 +501,7 @@ static int skge_set_ring_param(struct net_device *dev, struct ethtool_ringparam *p) { struct skge_port *skge = netdev_priv(dev); - int err; + int err = 0; if (p->rx_pending == 0 || p->rx_pending > MAX_RX_RING_SIZE || p->tx_pending < TX_LOW_WATER || p->tx_pending > MAX_TX_RING_SIZE) @@ -517,7 +517,7 @@ static int skge_set_ring_param(struct net_device *dev, dev_close(dev); } - return 0; + return err; } static u32 skge_get_msglevel(struct net_device *netdev) |
