diff options
author | Jon Mason <jdmason@kudzu.us> | 2012-07-09 14:09:25 +0000 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2012-07-10 23:24:56 -0700 |
commit | 5c8b73ca43dc6f419e02597d9942222b7987e74c (patch) | |
tree | 403dcd9a0297aaa620857508a22a8e7c2258f923 /drivers | |
parent | c0589fa78ae534acb741370872c4e13578d2f164 (diff) | |
download | op-kernel-dev-5c8b73ca43dc6f419e02597d9942222b7987e74c.zip op-kernel-dev-5c8b73ca43dc6f419e02597d9942222b7987e74c.tar.gz |
lance: remove unnecessary setting of skb->dev
skb->dev is being unnecessarily set during ring init. It is already being set
to the proper value when eth_type_trans is called on packet receive, and the
skb->dev is not referenced anywhere else in the code.
Signed-off-by: Jon Mason <jdmason@kudzu.us>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/net/ethernet/amd/lance.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/net/ethernet/amd/lance.c b/drivers/net/ethernet/amd/lance.c index a6e2e84..5c72843 100644 --- a/drivers/net/ethernet/amd/lance.c +++ b/drivers/net/ethernet/amd/lance.c @@ -873,10 +873,9 @@ lance_init_ring(struct net_device *dev, gfp_t gfp) skb = alloc_skb(PKT_BUF_SZ, GFP_DMA | gfp); lp->rx_skbuff[i] = skb; - if (skb) { - skb->dev = dev; + if (skb) rx_buff = skb->data; - } else + else rx_buff = kmalloc(PKT_BUF_SZ, GFP_DMA | gfp); if (rx_buff == NULL) lp->rx_ring[i].base = 0; |