summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorKAMBAROV, ZAUR <kambarov@berkeley.edu>2005-07-07 17:57:05 -0700
committerLinus Torvalds <torvalds@g5.osdl.org>2005-07-07 18:23:47 -0700
commit8f96c95680bfe66ff00c91859d4c73edf539b854 (patch)
tree306857acc1009e7d354aea71aa02a0ea5d40fefd /drivers
parent5bbcfd9000887c0da7d57cc7b3ac869fc0dd5aa9 (diff)
downloadop-kernel-dev-8f96c95680bfe66ff00c91859d4c73edf539b854.zip
op-kernel-dev-8f96c95680bfe66ff00c91859d4c73edf539b854.tar.gz
[PATCH] coverity: fix fbsysfs null pointer check
Correctly test for a null pointer before going and dereferencing it. This defect was found automatically by Coverity Prevent, a static analysis tool. Signed-off-by: Zaur Kambarov <zkambarov@coverity.com> Cc: <linux-fbdev-devel@lists.sourceforge.net> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/video/fbsysfs.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/video/fbsysfs.c b/drivers/video/fbsysfs.c
index 7dfbf39..ddc9443 100644
--- a/drivers/video/fbsysfs.c
+++ b/drivers/video/fbsysfs.c
@@ -256,7 +256,7 @@ static ssize_t show_cmap(struct class_device *class_device, char *buf)
unsigned int offset = 0, i;
if (!fb_info->cmap.red || !fb_info->cmap.blue ||
- fb_info->cmap.green || fb_info->cmap.transp)
+ !fb_info->cmap.green || !fb_info->cmap.transp)
return -EINVAL;
for (i = 0; i < fb_info->cmap.len; i++) {
OpenPOWER on IntegriCloud