diff options
| author | Akinobu Mita <akinobu.mita@gmail.com> | 2006-11-16 01:19:25 -0800 |
|---|---|---|
| committer | Linus Torvalds <torvalds@woody.osdl.org> | 2006-11-16 11:43:38 -0800 |
| commit | 6897083abfb0156b533ab8ac42c47f68c550ca9e (patch) | |
| tree | 511eb7ea465123ddac43bbfe1ef8e0ecb721a7f9 /drivers | |
| parent | 55aa601e14cbec987fa577a895e9297df1d0a71d (diff) | |
| download | op-kernel-dev-6897083abfb0156b533ab8ac42c47f68c550ca9e.zip op-kernel-dev-6897083abfb0156b533ab8ac42c47f68c550ca9e.tar.gz | |
[PATCH] dell_rbu: fix error check
platform_device_register_simple() returns error code as pointer when it
fails. The return value should be checked by IS_ERR().
Cc: Abhay Salunke <abhay_salunke@dell.com>
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: Matt Domsch <Matt_Domsch@dell.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/firmware/dell_rbu.c | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/drivers/firmware/dell_rbu.c b/drivers/firmware/dell_rbu.c index 08b1617..fc702e4 100644 --- a/drivers/firmware/dell_rbu.c +++ b/drivers/firmware/dell_rbu.c @@ -705,17 +705,16 @@ static struct bin_attribute rbu_packet_size_attr = { static int __init dcdrbu_init(void) { - int rc = 0; + int rc; spin_lock_init(&rbu_data.lock); init_packet_head(); - rbu_device = - platform_device_register_simple("dell_rbu", -1, NULL, 0); - if (!rbu_device) { + rbu_device = platform_device_register_simple("dell_rbu", -1, NULL, 0); + if (IS_ERR(rbu_device)) { printk(KERN_ERR "dell_rbu:%s:platform_device_register_simple " "failed\n", __FUNCTION__); - return -EIO; + return PTR_ERR(rbu_device); } rc = sysfs_create_bin_file(&rbu_device->dev.kobj, &rbu_data_attr); |
