diff options
| author | Keith Packard <keithp@keithp.com> | 2008-12-08 11:12:28 -0800 |
|---|---|---|
| committer | Dave Airlie <airlied@redhat.com> | 2008-12-09 15:37:24 +1000 |
| commit | b60678a75d44fa9d5969f79781bd856ad5858609 (patch) | |
| tree | 2bdc4a7f9a3a89cfd83555327185a36399426b51 /drivers | |
| parent | 15c35334c9b7a11f66ddf7fea9367884e1f5414f (diff) | |
| download | op-kernel-dev-b60678a75d44fa9d5969f79781bd856ad5858609.zip op-kernel-dev-b60678a75d44fa9d5969f79781bd856ad5858609.tar.gz | |
drm/i915: Disable the GM965 MSI errata workaround.
Since applying the fix suggested by the errata (disabling MSI), we've had
issues with interrupts being stuck on despite IIR being 0 on GM965 hardware.
Most reporters of the issue have confirmed that turning MSI back on fixes
things, and given the difficulties experienced in getting reliable MSI working
on Linux, it's believable that the errata was about software issues and not
actual hardware issues.
Signed-off-by: Dave Airlie <airlied@redhat.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/gpu/drm/i915/i915_dma.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c index ba89b42..553dd4b 100644 --- a/drivers/gpu/drm/i915/i915_dma.c +++ b/drivers/gpu/drm/i915/i915_dma.c @@ -847,9 +847,10 @@ int i915_driver_load(struct drm_device *dev, unsigned long flags) * and the registers being closely associated. * * According to chipset errata, on the 965GM, MSI interrupts may - * be lost or delayed + * be lost or delayed, but we use them anyways to avoid + * stuck interrupts on some machines. */ - if (!IS_I945G(dev) && !IS_I945GM(dev) && !IS_I965GM(dev)) + if (!IS_I945G(dev) && !IS_I945GM(dev)) pci_enable_msi(dev->pdev); intel_opregion_init(dev); |
