diff options
| author | Michael S. Tsirkin <mst@mellanox.co.il> | 2006-02-07 16:39:26 -0800 |
|---|---|---|
| committer | Roland Dreier <rolandd@cisco.com> | 2006-02-07 16:39:26 -0800 |
| commit | 7bcb974ef6a0ae903888272c92c66ea779388c01 (patch) | |
| tree | 926245a2e120dd5884f3bab92020612fcfbd78bf /drivers | |
| parent | 479a079663bd4c5f3d2714643b1b8c406aaba3e0 (diff) | |
| download | op-kernel-dev-7bcb974ef6a0ae903888272c92c66ea779388c01.zip op-kernel-dev-7bcb974ef6a0ae903888272c92c66ea779388c01.tar.gz | |
IPoIB: Fix another send-only join race
Further, there's an additional issue that I saw in testing:
ipoib_mcast_send may get called when priv->broadcast is NULL (e.g. if
the device was downed and then upped internally because of a port
event).
If this happends and the send-only join request gets completed before
priv->broadcast is set, we get an oops.
Signed-off-by: Michael S. Tsirkin <mst@mellanox.co.il>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/infiniband/ulp/ipoib/ipoib_multicast.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/infiniband/ulp/ipoib/ipoib_multicast.c b/drivers/infiniband/ulp/ipoib/ipoib_multicast.c index 1c71482..932bf13 100644 --- a/drivers/infiniband/ulp/ipoib/ipoib_multicast.c +++ b/drivers/infiniband/ulp/ipoib/ipoib_multicast.c @@ -701,7 +701,7 @@ void ipoib_mcast_send(struct net_device *dev, union ib_gid *mgid, */ spin_lock(&priv->lock); - if (!test_bit(IPOIB_MCAST_STARTED, &priv->flags)) { + if (!test_bit(IPOIB_MCAST_STARTED, &priv->flags) || !priv->broadcast) { ++priv->stats.tx_dropped; dev_kfree_skb_any(skb); goto unlock; |
