summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorLee Nipper <lee.nipper@gmail.com>2010-07-19 14:11:24 +0800
committerHerbert Xu <herbert@gondor.apana.org.au>2010-07-19 14:11:24 +0800
commit7260042b2d0397e7a8735ca47cd7839a5bb1210b (patch)
treeda92181f60f67f1e82378e59edfd13def6a51fe7 /drivers
parent2716fbf63ee39eadc1aa9b3841b20f75b99a9bc3 (diff)
downloadop-kernel-dev-7260042b2d0397e7a8735ca47cd7839a5bb1210b.zip
op-kernel-dev-7260042b2d0397e7a8735ca47cd7839a5bb1210b.tar.gz
crypto: talitos - fix bug in sg_copy_end_to_buffer
In function sg_copy_end_to_buffer, too much data is copied when a segment in the scatterlist has .length greater than the requested copy length. This patch adds the limit checks to fix this bug of over copying, which affected only the ahash algorithms. Signed-off-by: Lee Nipper <lee.nipper@gmail.com> Acked-by: Kim Phillips <kim.phillips@freescale.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/crypto/talitos.c6
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c
index 637c105..bd78acf 100644
--- a/drivers/crypto/talitos.c
+++ b/drivers/crypto/talitos.c
@@ -1183,10 +1183,14 @@ static size_t sg_copy_end_to_buffer(struct scatterlist *sgl, unsigned int nents,
/* Copy part of this segment */
ignore = skip - offset;
len = miter.length - ignore;
+ if (boffset + len > buflen)
+ len = buflen - boffset;
memcpy(buf + boffset, miter.addr + ignore, len);
} else {
- /* Copy all of this segment */
+ /* Copy all of this segment (up to buflen) */
len = miter.length;
+ if (boffset + len > buflen)
+ len = buflen - boffset;
memcpy(buf + boffset, miter.addr, len);
}
boffset += len;
OpenPOWER on IntegriCloud