diff options
| author | Pali Rohár <pali.rohar@gmail.com> | 2016-06-18 00:54:44 +0200 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2016-06-18 12:55:20 -0700 |
| commit | 053ea640818812313892ec4f370f5cfac42fd355 (patch) | |
| tree | 75c74adedf6d7f6725a3ef9466430e3f035443e4 /drivers | |
| parent | 5edb56491d4812c42175980759da53388e5d86f5 (diff) | |
| download | op-kernel-dev-053ea640818812313892ec4f370f5cfac42fd355.zip op-kernel-dev-053ea640818812313892ec4f370f5cfac42fd355.tar.gz | |
hwmon: (dell-smm) Fail in ioctl I8K_BIOS_VERSION when bios version is not a number
ABI of I8K_BIOS_VERSION ioctl can return only number. But new BIOS versions
contain also other characters, which does not fit into that ABI. So in case
of non digit values return -EINVAL.
Reported-by: Mario Limonciello <Mario_Limonciello@dell.com>
Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/hwmon/dell-smm-hwmon.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c index c43318d..480b2fa 100644 --- a/drivers/hwmon/dell-smm-hwmon.c +++ b/drivers/hwmon/dell-smm-hwmon.c @@ -35,6 +35,7 @@ #include <linux/uaccess.h> #include <linux/io.h> #include <linux/sched.h> +#include <linux/ctype.h> #include <linux/i8k.h> @@ -387,6 +388,10 @@ i8k_ioctl_unlocked(struct file *fp, unsigned int cmd, unsigned long arg) switch (cmd) { case I8K_BIOS_VERSION: + if (!isdigit(bios_version[0]) || !isdigit(bios_version[1]) || + !isdigit(bios_version[2])) + return -EINVAL; + val = (bios_version[0] << 16) | (bios_version[1] << 8) | bios_version[2]; break; |
