diff options
| author | Andrew Klossner <andrew@cesa.opbu.xerox.com> | 2009-03-12 13:36:39 +0100 |
|---|---|---|
| committer | Jean Delvare <khali@linux-fr.org> | 2009-03-12 13:36:39 +0100 |
| commit | 51b3e2700177b89fdb0d985926ce777a7ad52b15 (patch) | |
| tree | fd616c0db5df31f27d435196a575ec93e2fa5eba /drivers | |
| parent | e267d25005c861fe6afda343f044536342c9f8b4 (diff) | |
| download | op-kernel-dev-51b3e2700177b89fdb0d985926ce777a7ad52b15.zip op-kernel-dev-51b3e2700177b89fdb0d985926ce777a7ad52b15.tar.gz | |
hwmon: (f75375s) Remove unnecessary and confusing initialization
f75375_probe calls i2c_get_clientdata to initialize the data pointer,
but there isn't yet any client data to get, and the value is never
used before the variable is assigned a new value seven lines later.
The call doesn't hurt anything and wastes only a couple of cycles.
The reason to fix it is because this module serves as an example to
hackers writing new hwmon drivers, and this part of the example is
confusing.
Signed-off-by: Andrew Klossner <andrew@cesa.opbu.xerox.com>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/hwmon/f75375s.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hwmon/f75375s.c b/drivers/hwmon/f75375s.c index 1692de3..18a1ba8 100644 --- a/drivers/hwmon/f75375s.c +++ b/drivers/hwmon/f75375s.c @@ -617,7 +617,7 @@ static void f75375_init(struct i2c_client *client, struct f75375_data *data, static int f75375_probe(struct i2c_client *client, const struct i2c_device_id *id) { - struct f75375_data *data = i2c_get_clientdata(client); + struct f75375_data *data; struct f75375s_platform_data *f75375s_pdata = client->dev.platform_data; int err; |
