summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorDeepak Saxena <dsaxena@plexity.net>2005-09-21 09:55:35 -0700
committerLinus Torvalds <torvalds@g5.osdl.org>2005-09-21 10:11:54 -0700
commit8b20f6da20d874a58becc7a08b130c4382ea7325 (patch)
tree351214ad8719c6d46291d21b212996db46aef0dd /drivers
parent40da47e1159b89f2df5c718d2d5e269ced72b541 (diff)
downloadop-kernel-dev-8b20f6da20d874a58becc7a08b130c4382ea7325.zip
op-kernel-dev-8b20f6da20d874a58becc7a08b130c4382ea7325.tar.gz
[PATCH] Fix I2O config-osm init to return proper error
We currently unregister the config-osm driver if initialization of the legacy ioctl() handlers failed but still return success. We should be returning -EBUSY in this case. Signed-off-by: Deepak Saxena <dsaxena@plexity.net> Cc: Markus Lidel <Markus.Lidel@shadowconnect.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/message/i2o/config-osm.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/message/i2o/config-osm.c b/drivers/message/i2o/config-osm.c
index af32ab4..10432f6 100644
--- a/drivers/message/i2o/config-osm.c
+++ b/drivers/message/i2o/config-osm.c
@@ -56,8 +56,11 @@ static int __init i2o_config_init(void)
return -EBUSY;
}
#ifdef CONFIG_I2O_CONFIG_OLD_IOCTL
- if (i2o_config_old_init())
+ if (i2o_config_old_init()) {
+ osm_err("old config handler initialization failed\n");
i2o_driver_unregister(&i2o_config_driver);
+ return -EBUSY;
+ }
#endif
return 0;
OpenPOWER on IntegriCloud