summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorMichael Buesch <mb@bu3sch.de>2009-07-19 21:40:39 +0200
committerStefan Richter <stefanr@s5r6.in-berlin.de>2009-09-12 14:48:40 +0200
commit64549e9357e5222a73e41aa87372b37abb047720 (patch)
tree0262ec2f55cd27294601e71fa0da14f90df9c8c2 /drivers
parent74fca6a42863ffacaf7ba6f1936a9f228950f657 (diff)
downloadop-kernel-dev-64549e9357e5222a73e41aa87372b37abb047720.zip
op-kernel-dev-64549e9357e5222a73e41aa87372b37abb047720.tar.gz
ieee1394: raw1394: Do not leak memory on failed trylock.
Do not leak the allocated memory in case the mutex_trylock() failed to acquire the lock. Signed-off-by: Michael Buesch <mb@bu3sch.de> This bug does not happen in practice: All raw1394 clients use libraw1394, and accesses to a libraw1394 handle need to be serialized by the client. This is documented in libraw1394's API reference. Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/ieee1394/raw1394.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/ieee1394/raw1394.c b/drivers/ieee1394/raw1394.c
index da5f882..0bc3d78 100644
--- a/drivers/ieee1394/raw1394.c
+++ b/drivers/ieee1394/raw1394.c
@@ -2272,8 +2272,10 @@ static ssize_t raw1394_write(struct file *file, const char __user * buffer,
return -EFAULT;
}
- if (!mutex_trylock(&fi->state_mutex))
+ if (!mutex_trylock(&fi->state_mutex)) {
+ free_pending_request(req);
return -EAGAIN;
+ }
switch (fi->state) {
case opened:
OpenPOWER on IntegriCloud