summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorAntti Kaijanmäki <antti.kaijanmaki@nomovok.com>2009-11-23 10:54:47 -0800
committerDavid S. Miller <davem@davemloft.net>2009-11-23 10:54:47 -0800
commitdcfcb256cc23c4436691b0fe677275306699d6a1 (patch)
tree15df747529bf1da7c646e877675b202797508a21 /drivers
parent9ce673d5e919966efc1ef5adf20248e6ecc62724 (diff)
downloadop-kernel-dev-dcfcb256cc23c4436691b0fe677275306699d6a1.zip
op-kernel-dev-dcfcb256cc23c4436691b0fe677275306699d6a1.tar.gz
hso: fix soft-lockup
Fix soft-lockup in hso.c which is triggered on SMP machine when modem is removed while file descriptor(s) under /dev are still open: old version called kref_put() too early which resulted in destroying hso_serial and hso_device objects which were still used later on. Signed-off-by: Antti Kaijanmäki <antti.kaijanmaki@nomovok.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/net/usb/hso.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
index 746839b..43bc3fc 100644
--- a/drivers/net/usb/hso.c
+++ b/drivers/net/usb/hso.c
@@ -1363,7 +1363,7 @@ static void hso_serial_close(struct tty_struct *tty, struct file *filp)
/* reset the rts and dtr */
/* do the actual close */
serial->open_count--;
- kref_put(&serial->parent->ref, hso_serial_ref_free);
+
if (serial->open_count <= 0) {
serial->open_count = 0;
spin_lock_irq(&serial->serial_lock);
@@ -1383,6 +1383,8 @@ static void hso_serial_close(struct tty_struct *tty, struct file *filp)
usb_autopm_put_interface(serial->parent->interface);
mutex_unlock(&serial->parent->mutex);
+
+ kref_put(&serial->parent->ref, hso_serial_ref_free);
}
/* close the requested serial port */
OpenPOWER on IntegriCloud