diff options
| author | Jay Fenlason <fenlason@redhat.com> | 2008-10-16 15:51:59 -0400 |
|---|---|---|
| committer | Stefan Richter <stefanr@s5r6.in-berlin.de> | 2008-10-26 10:26:59 +0100 |
| commit | 4f9740d4f5a17fa6a1b097fa3ccdfb7246660307 (patch) | |
| tree | 72ba1bd1f03d2b6372c067f917de0092dd76ce30 /drivers | |
| parent | be585c07dd577faac26014db4246e6d7c7a131e7 (diff) | |
| download | op-kernel-dev-4f9740d4f5a17fa6a1b097fa3ccdfb7246660307.zip op-kernel-dev-4f9740d4f5a17fa6a1b097fa3ccdfb7246660307.tar.gz | |
firewire: Survive more than 256 bus resets
The "color" is used during the topology building after a bus reset,
hovever in "struct fw_node"s it is stored in a u8, but in struct fw_card
it is stored in an int. When the value wraps in one struct, but not
the other, disaster strikes.
Signed-off-by: Jay Fenlason <fenlason@redhat.com>
Fixes http://bugzilla.kernel.org/show_bug.cgi?id=10922.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/firewire/fw-transaction.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/firewire/fw-transaction.h b/drivers/firewire/fw-transaction.h index 027f58ce..aed7dbb 100644 --- a/drivers/firewire/fw-transaction.h +++ b/drivers/firewire/fw-transaction.h @@ -248,7 +248,7 @@ struct fw_card { struct fw_node *local_node; struct fw_node *root_node; struct fw_node *irm_node; - int color; + u8 color; /* must be u8 to match the definition in struct fw_node */ int gap_count; bool beta_repeaters_present; |
