summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorGuenter Roeck <guenter.roeck@ericsson.com>2011-12-08 10:01:25 -0800
committerGuenter Roeck <guenter.roeck@ericsson.com>2012-01-05 08:19:30 -0800
commit3310600aa7bc11ead9b0324b972d13fb0e91bcaf (patch)
treef9dcb81de745d403ea902789142fa8d26e01364e /drivers
parent740f6be3ccc885ca103c90c48d3b3066239c585c (diff)
downloadop-kernel-dev-3310600aa7bc11ead9b0324b972d13fb0e91bcaf.zip
op-kernel-dev-3310600aa7bc11ead9b0324b972d13fb0e91bcaf.tar.gz
hwmon: (f75375s) Fix value range for PWM modes
Accepted value range for PWM modes was 0..4, even though only 0..3 is subsequently used. Limit permitted value range to 0..3 to avoid unpredictable behavior. Cc: Riku Voipio <riku.voipio@iki.fi> Reviewed-by: Bjoern Gerhart <oss@extracloud.de> Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/hwmon/f75375s.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hwmon/f75375s.c b/drivers/hwmon/f75375s.c
index 316c29a..777a665 100644
--- a/drivers/hwmon/f75375s.c
+++ b/drivers/hwmon/f75375s.c
@@ -309,7 +309,7 @@ static int set_pwm_enable_direct(struct i2c_client *client, int nr, int val)
struct f75375_data *data = i2c_get_clientdata(client);
u8 fanmode;
- if (val < 0 || val > 4)
+ if (val < 0 || val > 3)
return -EINVAL;
fanmode = f75375_read8(client, F75375_REG_FAN_TIMER);
OpenPOWER on IntegriCloud