summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorDavid Brownell <david-b@pacbell.net>2005-06-13 07:15:28 -0700
committerLinus Torvalds <torvalds@ppc970.osdl.org>2005-06-13 08:20:41 -0700
commitc22fa3acbc2ef79ea57217643f6cd6d226963069 (patch)
treed79cf44149684a0cefc825f1619f0fbd33ea7e59 /drivers
parentc0105338eb4e61e537ca34ae06921177cb6efcf0 (diff)
downloadop-kernel-dev-c22fa3acbc2ef79ea57217643f6cd6d226963069.zip
op-kernel-dev-c22fa3acbc2ef79ea57217643f6cd6d226963069.tar.gz
[PATCH] spin longer for ehci port reset completion
This makes the EHCI driver spin a bit longer before concluding that the port reset failed. "Obviously safe." It allows some devices to enumerate that previously didn't. We've seen a bunch of these problem reports recently, this will make some go away. As reported by Michael Zapf <Michael.Zapf@uni-kassel.de>, some EHCI controllers seem to take forever to finish port resets and produce "port N reset error -110" type errors. Spinning a bit longer helps. Signed-off-by: David Brownell <dbrownell@users.sourceforge.net> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/usb/host/ehci-hub.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/usb/host/ehci-hub.c b/drivers/usb/host/ehci-hub.c
index 429330bc..d7b4f79 100644
--- a/drivers/usb/host/ehci-hub.c
+++ b/drivers/usb/host/ehci-hub.c
@@ -439,9 +439,12 @@ static int ehci_hub_control (
/* force reset to complete */
writel (temp & ~PORT_RESET,
&ehci->regs->port_status [wIndex]);
+ /* REVISIT: some hardware needs 550+ usec to clear
+ * this bit; seems too long to spin routinely...
+ */
retval = handshake (
&ehci->regs->port_status [wIndex],
- PORT_RESET, 0, 500);
+ PORT_RESET, 0, 750);
if (retval != 0) {
ehci_err (ehci, "port %d reset error %d\n",
wIndex + 1, retval);
OpenPOWER on IntegriCloud