diff options
| author | Ohad Ben-Cohen <ohad@wizery.com> | 2012-01-31 15:23:41 +0200 |
|---|---|---|
| committer | Ohad Ben-Cohen <ohad@wizery.com> | 2012-02-22 18:28:49 +0200 |
| commit | cf59d3e9a715fd2b6ff96e4a3a130fceded09a64 (patch) | |
| tree | efc2040a4e7a60863589ee1b7415516dffbf7c90 /drivers | |
| parent | dd6da1c5e99a3b736b52370c504a2b8843cbfda6 (diff) | |
| download | op-kernel-dev-cf59d3e9a715fd2b6ff96e4a3a130fceded09a64.zip op-kernel-dev-cf59d3e9a715fd2b6ff96e4a3a130fceded09a64.tar.gz | |
remoteproc: bail out if firmware has different endianess
At this point we don't support remote processors that have
a different endianess than the host.
Look out for these unsupported scenarios, and bail out if
encountered.
Reported-by: Grant Likely <grant.likely@secretlab.ca>
Signed-off-by: Ohad Ben-Cohen <ohad@wizery.com>
Cc: Mark Grosen <mgrosen@ti.com>
Acked-by: Grant Likely <grant.likely@secretlab.ca>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/remoteproc/remoteproc_core.c | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c index 6212b82..567a3c5 100644 --- a/drivers/remoteproc/remoteproc_core.c +++ b/drivers/remoteproc/remoteproc_core.c @@ -39,6 +39,7 @@ #include <linux/elf.h> #include <linux/virtio_ids.h> #include <linux/virtio_ring.h> +#include <asm/byteorder.h> #include "remoteproc_internal.h" @@ -851,6 +852,16 @@ static int rproc_fw_sanity_check(struct rproc *rproc, const struct firmware *fw) ehdr = (struct elf32_hdr *)fw->data; + /* We assume the firmware has the same endianess as the host */ +# ifdef __LITTLE_ENDIAN + if (ehdr->e_ident[EI_DATA] != ELFDATA2LSB) { +# else /* BIG ENDIAN */ + if (ehdr->e_ident[EI_DATA] != ELFDATA2MSB) { +# endif + dev_err(dev, "Unsupported firmware endianess\n"); + return -EINVAL; + } + if (fw->size < ehdr->e_shoff + sizeof(struct elf32_shdr)) { dev_err(dev, "Image is too small\n"); return -EINVAL; |
