diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2013-01-30 10:07:31 +0300 |
|---|---|---|
| committer | James Bottomley <JBottomley@Parallels.com> | 2013-02-22 11:24:22 +0000 |
| commit | 50e9291578886099888b8169459c6f97626ccbfc (patch) | |
| tree | 73ebd2608393df83d10beaeead18c804aff79422 /drivers | |
| parent | 7c237c5f6d5c62724ccd82aecdcd1fd9bd71dc75 (diff) | |
| download | op-kernel-dev-50e9291578886099888b8169459c6f97626ccbfc.zip op-kernel-dev-50e9291578886099888b8169459c6f97626ccbfc.tar.gz | |
[SCSI] qla4xxx: don't free NULL dma pool
The error path calls dma_pool_free() on this path but "chap_table" is
NULL and "chap_dma" is uninitialized. It's cleaner to just return
directly.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Vikas Chaudhary <vikas.chaudhary@qlogic.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/scsi/qla4xxx/ql4_mbx.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/scsi/qla4xxx/ql4_mbx.c b/drivers/scsi/qla4xxx/ql4_mbx.c index 81e738d..160d336 100644 --- a/drivers/scsi/qla4xxx/ql4_mbx.c +++ b/drivers/scsi/qla4xxx/ql4_mbx.c @@ -1420,10 +1420,8 @@ int qla4xxx_get_chap(struct scsi_qla_host *ha, char *username, char *password, dma_addr_t chap_dma; chap_table = dma_pool_alloc(ha->chap_dma_pool, GFP_KERNEL, &chap_dma); - if (chap_table == NULL) { - ret = -ENOMEM; - goto exit_get_chap; - } + if (chap_table == NULL) + return -ENOMEM; chap_size = sizeof(struct ql4_chap_table); memset(chap_table, 0, chap_size); |
