diff options
| author | Julia Lawall <Julia.Lawall@lip6.fr> | 2013-08-19 10:51:52 +0200 |
|---|---|---|
| committer | Wim Van Sebroeck <wim@iguana.be> | 2013-09-10 21:20:44 +0200 |
| commit | 8ecc7d2b2207ed9642e3d0140bfaa8c93a6ea47f (patch) | |
| tree | c08f74236439e08926ddb83395e3a7d37aceb26a /drivers/watchdog | |
| parent | 086f2d500c693e2d175fe06c9dbfde1c69a26644 (diff) | |
| download | op-kernel-dev-8ecc7d2b2207ed9642e3d0140bfaa8c93a6ea47f.zip op-kernel-dev-8ecc7d2b2207ed9642e3d0140bfaa8c93a6ea47f.tar.gz | |
watchdog: simplify platform_get_resource_byname/devm_ioremap_resource
Remove unneeded error handling on the result of a call to
platform_get_resource_byname when the value is passed to devm_ioremap_resource.
A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
expression pdev,res,e,e1;
expression ret != 0;
identifier l;
@@
res = platform_get_resource_byname(...);
- if (res == NULL) { ... \(goto l;\|return ret;\) }
e = devm_ioremap_resource(e1, res);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
Diffstat (limited to 'drivers/watchdog')
| -rw-r--r-- | drivers/watchdog/ar7_wdt.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/drivers/watchdog/ar7_wdt.c b/drivers/watchdog/ar7_wdt.c index 2f3cc8f..b3709f9 100644 --- a/drivers/watchdog/ar7_wdt.c +++ b/drivers/watchdog/ar7_wdt.c @@ -280,11 +280,6 @@ static int ar7_wdt_probe(struct platform_device *pdev) ar7_regs_wdt = platform_get_resource_byname(pdev, IORESOURCE_MEM, "regs"); - if (!ar7_regs_wdt) { - pr_err("could not get registers resource\n"); - return -ENODEV; - } - ar7_wdt = devm_ioremap_resource(&pdev->dev, ar7_regs_wdt); if (IS_ERR(ar7_wdt)) return PTR_ERR(ar7_wdt); |
