diff options
author | Julia Lawall <Julia.Lawall@lip6.fr> | 2016-09-01 19:35:26 +0200 |
---|---|---|
committer | Wim Van Sebroeck <wim@iguana.be> | 2016-09-24 08:50:10 +0200 |
commit | 85f15cfc213da88d9eb01c943be454328b104f3c (patch) | |
tree | d1505e371dd0ca9654fea58181279378e5bce5e1 /drivers/watchdog/softdog.c | |
parent | 7123f253f02b7370ad25d9047fd91a5ef6ae551f (diff) | |
download | op-kernel-dev-85f15cfc213da88d9eb01c943be454328b104f3c.zip op-kernel-dev-85f15cfc213da88d9eb01c943be454328b104f3c.tar.gz |
watchdog: constify watchdog_ops structures
Check for watchdog_ops structures that are only stored in the ops field of
a watchdog_device structure. This field is declared const, so watchdog_ops
structures that have this property can be declared as const also.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r disable optional_qualifier@
identifier i;
position p;
@@
static struct watchdog_ops i@p = { ... };
@ok@
identifier r.i;
struct watchdog_device e;
position p;
@@
e.ops = &i@p;
@bad@
position p != {r.p,ok.p};
identifier r.i;
struct watchdog_ops e;
@@
e@i@p
@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
struct watchdog_ops i = { ... };
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
Diffstat (limited to 'drivers/watchdog/softdog.c')
-rw-r--r-- | drivers/watchdog/softdog.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/watchdog/softdog.c b/drivers/watchdog/softdog.c index b067edf..1ae469e 100644 --- a/drivers/watchdog/softdog.c +++ b/drivers/watchdog/softdog.c @@ -92,7 +92,7 @@ static struct watchdog_info softdog_info = { .options = WDIOF_SETTIMEOUT | WDIOF_KEEPALIVEPING | WDIOF_MAGICCLOSE, }; -static struct watchdog_ops softdog_ops = { +static const struct watchdog_ops softdog_ops = { .owner = THIS_MODULE, .start = softdog_ping, .stop = softdog_stop, |