diff options
author | Michael S. Tsirkin <mst@redhat.com> | 2014-10-14 10:40:29 +1030 |
---|---|---|
committer | Rusty Russell <rusty@rustcorp.com.au> | 2014-10-15 10:24:53 +1030 |
commit | 6fbc198cf623944ab60a1db6d306a4d55cdd820d (patch) | |
tree | f0e9102dc35317a14829f0109ef999bc65379cd8 /drivers/virtio/virtio.c | |
parent | 7ec62d421bdf29cb31101ae2689f7f3a9906289a (diff) | |
download | op-kernel-dev-6fbc198cf623944ab60a1db6d306a4d55cdd820d.zip op-kernel-dev-6fbc198cf623944ab60a1db6d306a4d55cdd820d.tar.gz |
virtio_pci: fix virtio spec compliance on restore
On restore, virtio pci does the following:
+ set features
+ init vqs etc - device can be used at this point!
+ set ACKNOWLEDGE,DRIVER and DRIVER_OK status bits
This is in violation of the virtio spec, which
requires the following order:
- ACKNOWLEDGE
- DRIVER
- init vqs
- DRIVER_OK
This behaviour will break with hypervisors that assume spec compliant
behaviour. It seems like a good idea to have this patch applied to
stable branches to reduce the support butden for the hypervisors.
Cc: stable@vger.kernel.org
Cc: Amit Shah <amit.shah@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Diffstat (limited to 'drivers/virtio/virtio.c')
0 files changed, 0 insertions, 0 deletions