summaryrefslogtreecommitdiffstats
path: root/drivers/video
diff options
context:
space:
mode:
authorChen Gang <gang.chen@asianux.com>2013-08-20 10:33:56 +0800
committerTomi Valkeinen <tomi.valkeinen@ti.com>2013-08-30 11:41:24 +0300
commit9bb40585c9d934db3585e1f422e2ffb1dd5e9631 (patch)
treeae644be218e1fd1ddeab3065ccb6bdef35d7c198 /drivers/video
parent51617d1bc8f37df703295cf3fd472da15b076ecb (diff)
downloadop-kernel-dev-9bb40585c9d934db3585e1f422e2ffb1dd5e9631.zip
op-kernel-dev-9bb40585c9d934db3585e1f422e2ffb1dd5e9631.tar.gz
drivers: video: fbcmap: remove the redundency and incorrect checkings
fb_set_cmap() already checks the parameters, so need remove the redundancy checking. This redundancy checking is also incorrect, the related warning: drivers/video/fbcmap.c:288:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] Signed-off-by: Chen Gang <gang.chen@asianux.com> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Diffstat (limited to 'drivers/video')
-rw-r--r--drivers/video/fbcmap.c7
1 files changed, 1 insertions, 6 deletions
diff --git a/drivers/video/fbcmap.c b/drivers/video/fbcmap.c
index 5c3960d..f89245b 100644
--- a/drivers/video/fbcmap.c
+++ b/drivers/video/fbcmap.c
@@ -285,13 +285,8 @@ int fb_set_user_cmap(struct fb_cmap_user *cmap, struct fb_info *info)
rc = -ENODEV;
goto out;
}
- if (cmap->start < 0 || (!info->fbops->fb_setcolreg &&
- !info->fbops->fb_setcmap)) {
- rc = -EINVAL;
- goto out1;
- }
+
rc = fb_set_cmap(&umap, info);
-out1:
unlock_fb_info(info);
out:
fb_dealloc_cmap(&umap);
OpenPOWER on IntegriCloud