summaryrefslogtreecommitdiffstats
path: root/drivers/video
diff options
context:
space:
mode:
authorJulia Lawall <Julia.Lawall@lip6.fr>2014-08-08 12:07:55 +0200
committerTomi Valkeinen <tomi.valkeinen@ti.com>2014-08-26 15:52:38 +0300
commit68ecfe2fe2e6c636bb7e2cf616e658e342e05362 (patch)
tree633eb739496cb962e79dce191f548796c112d7bd /drivers/video
parent52addcf9d6669fa439387610bc65c92fa0980cef (diff)
downloadop-kernel-dev-68ecfe2fe2e6c636bb7e2cf616e658e342e05362.zip
op-kernel-dev-68ecfe2fe2e6c636bb7e2cf616e658e342e05362.tar.gz
video: of: display_timing: delete unneeded test before of_node_put
Of_node_put supports NULL as its argument, so the initial test is not necessary. Furthermore, native_mode cannot be NULL at this point. Suggested by Uwe Kleine-König. The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression e; @@ -if (e) of_node_put(e); // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Diffstat (limited to 'drivers/video')
-rw-r--r--drivers/video/of_display_timing.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/video/of_display_timing.c b/drivers/video/of_display_timing.c
index 987edf1..339f831 100644
--- a/drivers/video/of_display_timing.c
+++ b/drivers/video/of_display_timing.c
@@ -233,8 +233,7 @@ struct display_timings *of_get_display_timings(struct device_node *np)
return disp;
timingfail:
- if (native_mode)
- of_node_put(native_mode);
+ of_node_put(native_mode);
display_timings_release(disp);
entryfail:
kfree(disp);
OpenPOWER on IntegriCloud