summaryrefslogtreecommitdiffstats
path: root/drivers/video/vermilion
diff options
context:
space:
mode:
authorThomas Gleixner <tglx@linutronix.de>2008-01-30 13:34:07 +0100
committerIngo Molnar <mingo@elte.hu>2008-01-30 13:34:07 +0100
commitd7c8f21a8cad0228c7c5ce2bb6dbd95d1ee49d13 (patch)
treed1e305bec62022a0bec82a3499a372c2c7c40583 /drivers/video/vermilion
parentd1028a154c65d7fadd1b2d0276c077014d401ec7 (diff)
downloadop-kernel-dev-d7c8f21a8cad0228c7c5ce2bb6dbd95d1ee49d13.zip
op-kernel-dev-d7c8f21a8cad0228c7c5ce2bb6dbd95d1ee49d13.tar.gz
x86: cpa: move flush to cpa
The set_memory_* and set_pages_* family of API's currently requires the callers to do a global tlb flush after the function call; forgetting this is a very nasty deathtrap. This patch moves the global tlb flush into each of the callers Signed-off-by: Arjan van de Ven <arjan@linux.intel.com> Signed-off-by: Ingo Molnar <mingo@elte.hu> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Diffstat (limited to 'drivers/video/vermilion')
-rw-r--r--drivers/video/vermilion/vermilion.c6
1 files changed, 0 insertions, 6 deletions
diff --git a/drivers/video/vermilion/vermilion.c b/drivers/video/vermilion/vermilion.c
index fb72778..1c65666 100644
--- a/drivers/video/vermilion/vermilion.c
+++ b/drivers/video/vermilion/vermilion.c
@@ -124,13 +124,8 @@ static int vmlfb_alloc_vram_area(struct vram_area *va, unsigned max_order,
/*
* Change caching policy of the linear kernel map to avoid
* mapping type conflicts with user-space mappings.
- * The first global_flush_tlb() is really only there to do a global
- * wbinvd().
*/
-
- global_flush_tlb();
set_pages_uc(virt_to_page(va->logical), va->size >> PAGE_SHIFT);
- global_flush_tlb();
printk(KERN_DEBUG MODULE_NAME
": Allocated %ld bytes vram area at 0x%08lx\n",
@@ -156,7 +151,6 @@ static void vmlfb_free_vram_area(struct vram_area *va)
set_pages_wb(virt_to_page(va->logical),
va->size >> PAGE_SHIFT);
- global_flush_tlb();
/*
* Decrease the usage count on the pages we've used
OpenPOWER on IntegriCloud