diff options
| author | Liu Yuan <tailai.ly@taobao.com> | 2011-04-18 10:44:38 +0000 |
|---|---|---|
| committer | Paul Mundt <lethal@linux-sh.org> | 2011-05-24 16:07:50 +0900 |
| commit | 94cd1ae2fd251fd8206c043ce91a99a45439a116 (patch) | |
| tree | 1267c47adb8cfb53f7070c266c78b77d423a9f15 /drivers/video/udlfb.c | |
| parent | 6dbdf2a1cee23c34a66a35cfa2ae48e62e268dcb (diff) | |
| download | op-kernel-dev-94cd1ae2fd251fd8206c043ce91a99a45439a116.zip op-kernel-dev-94cd1ae2fd251fd8206c043ce91a99a45439a116.tar.gz | |
video, udlfb: Fix two build warnings about 'ignoring return value'
build warning:
...
drivers/video/udlfb.c:1590: warning: ignoring return value of ‘device_create_file’, declared with attribute warn_unused_result
drivers/video/udlfb.c:1592: warning: ignoring return value of ‘device_create_bin_file’, declared with attribute warn_unused_result
...
So add two checks to get rid of 'em.
Signed-off-by: Liu Yuan <tailai.ly@taobao.com>
Signed-off-by: Paul Mundt <lethal@linux-sh.org>
Diffstat (limited to 'drivers/video/udlfb.c')
| -rw-r--r-- | drivers/video/udlfb.c | 19 |
1 files changed, 16 insertions, 3 deletions
diff --git a/drivers/video/udlfb.c b/drivers/video/udlfb.c index 695066b..14b152a 100644 --- a/drivers/video/udlfb.c +++ b/drivers/video/udlfb.c @@ -1587,10 +1587,19 @@ static int dlfb_usb_probe(struct usb_interface *interface, goto error; } - for (i = 0; i < ARRAY_SIZE(fb_device_attrs); i++) - device_create_file(info->dev, &fb_device_attrs[i]); + for (i = 0; i < ARRAY_SIZE(fb_device_attrs); i++) { + retval = device_create_file(info->dev, &fb_device_attrs[i]); + if (retval) { + pr_err("device_create_file failed %d\n", retval); + goto err_del_attrs; + } + } - device_create_bin_file(info->dev, &edid_attr); + retval = device_create_bin_file(info->dev, &edid_attr); + if (retval) { + pr_err("device_create_bin_file failed %d\n", retval); + goto err_del_attrs; + } pr_info("DisplayLink USB device /dev/fb%d attached. %dx%d resolution." " Using %dK framebuffer memory\n", info->node, @@ -1599,6 +1608,10 @@ static int dlfb_usb_probe(struct usb_interface *interface, info->fix.smem_len * 2 : info->fix.smem_len) >> 10); return 0; +err_del_attrs: + for (i -= 1; i >= 0; i--) + device_remove_file(info->dev, &fb_device_attrs[i]); + error: if (dev) { |
