diff options
author | Julia Lawall <julia@diku.dk> | 2011-04-01 14:23:47 +0000 |
---|---|---|
committer | Paul Mundt <lethal@linux-sh.org> | 2011-04-06 09:44:57 -0700 |
commit | a8c908d353e52336b864025dbd8253134c3f5411 (patch) | |
tree | a94cf9d1774028e08803f14fdd07819d139d5899 /drivers/video/savage | |
parent | b73a21fc66fee35b41db755abebfacba48b2fc76 (diff) | |
download | op-kernel-dev-a8c908d353e52336b864025dbd8253134c3f5411.zip op-kernel-dev-a8c908d353e52336b864025dbd8253134c3f5411.tar.gz |
drivers/video/bfin-lq035q1-fb.c: introduce missing kfree
Error handling code following a kmalloc should free the allocated data.
The semantic match that finds the problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@r exists@
local idexpression x;
statement S;
expression E;
identifier f,f1,l;
position p1,p2;
expression *ptr != NULL;
@@
x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
...
if (x == NULL) S
<... when != x
when != if (...) { <+...x...+> }
(
x->f1 = E
|
(x->f1 == NULL || ...)
|
f(...,x->f1,...)
)
...>
(
return \(0\|<+...x...+>\|ptr\);
|
return@p2 ...;
)
@script:python@
p1 << r.p1;
p2 << r.p2;
@@
print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Mike Frysinger <vapier@gentoo.org>
Signed-off-by: Paul Mundt <lethal@linux-sh.org>
Diffstat (limited to 'drivers/video/savage')
0 files changed, 0 insertions, 0 deletions