summaryrefslogtreecommitdiffstats
path: root/drivers/vfio
diff options
context:
space:
mode:
authorAlex Williamson <alex.williamson@redhat.com>2013-06-10 16:40:56 -0600
committerAlex Williamson <alex.williamson@redhat.com>2013-07-24 16:36:40 -0600
commitc64019302bbb0b445484d870e674ab34a19a18a1 (patch)
treeb8b33240f42bd0788d67c3632efbb309e071f1f7 /drivers/vfio
parentde9c7602ca25f52bbfeb52e7d85765fe70b92dce (diff)
downloadop-kernel-dev-c64019302bbb0b445484d870e674ab34a19a18a1.zip
op-kernel-dev-c64019302bbb0b445484d870e674ab34a19a18a1.tar.gz
vfio: Ignore sprurious notifies
Remove debugging WARN_ON if we get a spurious notify for a group that no longer exists. No reports of anyone hitting this, but it would likely be a race and not a bug if they did. Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Diffstat (limited to 'drivers/vfio')
-rw-r--r--drivers/vfio/vfio.c8
1 files changed, 3 insertions, 5 deletions
diff --git a/drivers/vfio/vfio.c b/drivers/vfio/vfio.c
index 6d18c3c..842f450 100644
--- a/drivers/vfio/vfio.c
+++ b/drivers/vfio/vfio.c
@@ -510,13 +510,11 @@ static int vfio_iommu_group_notifier(struct notifier_block *nb,
struct device *dev = data;
/*
- * Need to go through a group_lock lookup to get a reference or
- * we risk racing a group being removed. Leave a WARN_ON for
- * debuging, but if the group no longer exists, a spurious notify
- * is harmless.
+ * Need to go through a group_lock lookup to get a reference or we
+ * risk racing a group being removed. Ignore spurious notifies.
*/
group = vfio_group_try_get(group);
- if (WARN_ON(!group))
+ if (!group)
return NOTIFY_OK;
switch (action) {
OpenPOWER on IntegriCloud