diff options
author | Konrad Leszczynski <konrad.leszczynski@intel.com> | 2016-02-08 16:13:12 +0100 |
---|---|---|
committer | Felipe Balbi <felipe.balbi@linux.intel.com> | 2016-06-20 12:32:37 +0300 |
commit | 9cad39fe4e4a4fe95d8ea5a7b0692b0a6e89e38b (patch) | |
tree | 32add6d80507557753ae4bdcd9f97a44b26c0df6 /drivers/usb | |
parent | ab2a92e7a608c09f13baf1730b9ba24c73c35d52 (diff) | |
download | op-kernel-dev-9cad39fe4e4a4fe95d8ea5a7b0692b0a6e89e38b.zip op-kernel-dev-9cad39fe4e4a4fe95d8ea5a7b0692b0a6e89e38b.tar.gz |
usb: dwc3: fix for the isoc transfer EP_BUSY flag
commit f3af36511e60 ("usb: dwc3: gadget: always
enable IOC on bulk/interrupt transfers") ended up
regressing Isochronous endpoints by clearing
DWC3_EP_BUSY flag too early, which resulted in
choppy audio playback over USB.
Fix that by partially reverting original commit and
making sure that we check for isochronous endpoints.
Fixes: f3af36511e60 ("usb: dwc3: gadget: always enable IOC
on bulk/interrupt transfers")
Cc: <stable@vger.kernel.org>
Signed-off-by: Konrad Leszczynski <konrad.leszczynski@intel.com>
Signed-off-by: Rafal Redzimski <rafal.f.redzimski@intel.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Diffstat (limited to 'drivers/usb')
-rw-r--r-- | drivers/usb/dwc3/gadget.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index 5e7b2ba..867adc9 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -2058,6 +2058,10 @@ static int dwc3_cleanup_done_reqs(struct dwc3 *dwc, struct dwc3_ep *dep, return 1; } + if (usb_endpoint_xfer_isoc(dep->endpoint.desc)) + if ((event->status & DEPEVT_STATUS_IOC) && + (trb->ctrl & DWC3_TRB_CTRL_IOC)) + return 0; return 1; } |