diff options
| author | Cristian Birsan <cristian.birsan@microchip.com> | 2016-02-19 10:11:56 +0200 |
|---|---|---|
| committer | Felipe Balbi <balbi@kernel.org> | 2016-02-23 08:51:38 +0200 |
| commit | 4c2ba0c67394514f3f75c660c9f5d02e66a7efd4 (patch) | |
| tree | 5c114d1f06ba2b307cb7a86785ca761a43c272ff /drivers/usb | |
| parent | 8de4b3a3fcbc18e0aa62e9defe5c08821351be12 (diff) | |
| download | op-kernel-dev-4c2ba0c67394514f3f75c660c9f5d02e66a7efd4.zip op-kernel-dev-4c2ba0c67394514f3f75c660c9f5d02e66a7efd4.tar.gz | |
usb: musb: fix DMA for host mode
Commit ac33cdb16681 ("usb: musb: Remove ifdefs for musb_host_rx in
musb_host.c part5") introduces a problem setting DMA host mode.
The musb_advance_schedule() is called immediately after receiving an
endpoint RX interrupt without waiting for the DMA transfer to complete.
As a consequence when the dma complete interrupt arrives the in_qh
member of hw_ep is already null an the musb_host_rx() exits on !urb
error case. Fix the done condition that advances the musb schedule.
Signed-off-by: Cristian Birsan <cristian.birsan@microchip.com>
Signed-off-by: Joshua Henderson <joshua.henderson@microchip.com>
Tested-by: Ladislav Michl <ladis@linux-mips.org>
Signed-off-by: Felipe Balbi <balbi@kernel.org>
Diffstat (limited to 'drivers/usb')
| -rw-r--r-- | drivers/usb/musb/musb_host.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c index 79d0818..58487a4 100644 --- a/drivers/usb/musb/musb_host.c +++ b/drivers/usb/musb/musb_host.c @@ -2003,10 +2003,8 @@ void musb_host_rx(struct musb *musb, u8 epnum) qh->offset, urb->transfer_buffer_length); - done = musb_rx_dma_in_inventra_cppi41(c, hw_ep, qh, - urb, xfer_len, - iso_err); - if (done) + if (musb_rx_dma_in_inventra_cppi41(c, hw_ep, qh, urb, + xfer_len, iso_err)) goto finish; else dev_err(musb->controller, "error: rx_dma failed\n"); |
