summaryrefslogtreecommitdiffstats
path: root/drivers/usb
diff options
context:
space:
mode:
authorMichael Brunner <mibru@gmx.de>2010-03-10 23:26:37 +0100
committerGreg Kroah-Hartman <gregkh@suse.de>2010-03-19 07:24:23 -0700
commite549a17f698e266373f6757bd068d1e98397b4c0 (patch)
treeed8a5c743f6df8784adbfc11b1587026a25dc2ea /drivers/usb
parent7f56cfd253d929c06ce4ed5bfb99a8c6805075c9 (diff)
downloadop-kernel-dev-e549a17f698e266373f6757bd068d1e98397b4c0.zip
op-kernel-dev-e549a17f698e266373f6757bd068d1e98397b4c0.tar.gz
USB: cp210x: Remove double usb_control_msg from cp210x_set_config
This patch removes a double usb_control_msg that sets the cp210x configuration registers a second time when calling cp210x_set_config. For data sizes >2 the second write gets corrupted. The patch has been created against 2.6.34-rc1, but all cp210x driver revisions are affected. Signed-off-by: Michael Brunner <mibru@gmx.de> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb')
-rw-r--r--drivers/usb/serial/cp210x.c5
1 files changed, 0 insertions, 5 deletions
diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
index 507382b..ec9b044 100644
--- a/drivers/usb/serial/cp210x.c
+++ b/drivers/usb/serial/cp210x.c
@@ -313,11 +313,6 @@ static int cp210x_set_config(struct usb_serial_port *port, u8 request,
return -EPROTO;
}
- /* Single data value */
- result = usb_control_msg(serial->dev,
- usb_sndctrlpipe(serial->dev, 0),
- request, REQTYPE_HOST_TO_DEVICE, data[0],
- 0, NULL, 0, 300);
return 0;
}
OpenPOWER on IntegriCloud