diff options
| author | Alan Stern <stern@rowland.harvard.edu> | 2007-04-05 16:07:44 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2007-05-22 23:45:49 -0700 |
| commit | bf87ce5a06ed2cb13ad04f065706cf36ab021549 (patch) | |
| tree | b7af5152fad7cb09203d121bf647077cfe8ade49 /drivers/usb | |
| parent | ef7f6c7084b333c7524dcd297e0578d43733a2a2 (diff) | |
| download | op-kernel-dev-bf87ce5a06ed2cb13ad04f065706cf36ab021549.zip op-kernel-dev-bf87ce5a06ed2cb13ad04f065706cf36ab021549.tar.gz | |
USB: remove unneeded WARN_ON
This patch (as883) removes an out-of-date WARN_ON from the main HCD
endpoint-disable routine. The warning is triggered whenever an
endpoint is disabled while the root hub is suspended. In the past
that may not have been legal, but it definitely is legal now. Merely
unbinding a USB driver will do it.
Furthermore, I've never seen any occurrences of this warning that
really did signal an actual bug or error condition. At this point it
has outlived its purpose.
Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Diffstat (limited to 'drivers/usb')
| -rw-r--r-- | drivers/usb/core/hcd.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c index 40cf882..9ad2970 100644 --- a/drivers/usb/core/hcd.c +++ b/drivers/usb/core/hcd.c @@ -1175,10 +1175,6 @@ void usb_hcd_endpoint_disable (struct usb_device *udev, struct urb *urb; hcd = bus_to_hcd(udev->bus); - - WARN_ON (!HC_IS_RUNNING (hcd->state) && hcd->state != HC_STATE_HALT && - udev->state != USB_STATE_NOTATTACHED); - local_irq_disable (); /* ep is already gone from udev->ep_{in,out}[]; no more submits */ |
