summaryrefslogtreecommitdiffstats
path: root/drivers/usb
diff options
context:
space:
mode:
authorFelipe Balbi <balbi@ti.com>2015-07-07 13:45:23 -0500
committerFelipe Balbi <balbi@ti.com>2015-07-29 09:59:19 -0500
commitd9972f470bcb40947dd91af90f17f9cb01db1f41 (patch)
tree94f35b14df0f357168f3a68486847ec87923d4aa /drivers/usb
parent88167fc0b22aac0fe7b9c4fadf9c251a9f864f32 (diff)
downloadop-kernel-dev-d9972f470bcb40947dd91af90f17f9cb01db1f41.zip
op-kernel-dev-d9972f470bcb40947dd91af90f17f9cb01db1f41.tar.gz
usb: dwc3: core: remove unnecessary dev_warn()
When a SoC supports both PHY interfaces but doesn't define HSPHY in DT/pdata, we will get an unnecessary dev_warn() which can mislead users into thinking that they're missing something. Instead, let's just silently rely on a correct default. If the HW default is wrong, then HSPHY is required and USB won't work, this will be motivation enough for engineers to patch their way into a working setup. Reported-by: Murali Karicheri <m-karicheri2@ti.com> Signed-off-by: Felipe Balbi <balbi@ti.com>
Diffstat (limited to 'drivers/usb')
-rw-r--r--drivers/usb/dwc3/core.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index ff5773c..064123e 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -455,8 +455,6 @@ static int dwc3_phy_setup(struct dwc3 *dwc)
reg |= DWC3_GUSB2PHYCFG_ULPI_UTMI;
dwc3_writel(dwc->regs, DWC3_GUSB2PHYCFG(0), reg);
} else {
- dev_warn(dwc->dev, "HSPHY Interface not defined\n");
-
/* Relying on default value. */
if (!(reg & DWC3_GUSB2PHYCFG_ULPI_UTMI))
break;
OpenPOWER on IntegriCloud