summaryrefslogtreecommitdiffstats
path: root/drivers/usb
diff options
context:
space:
mode:
authorBogdan Mirea <Bogdan-Stefan_mirea@mentor.com>2017-04-30 13:21:26 +0300
committerFelipe Balbi <felipe.balbi@linux.intel.com>2017-05-16 14:11:04 +0300
commit844cf8a9d51f1d1e116d0bb18c353a2a94c70e79 (patch)
tree1aba56ae033ac8b08f305c3d9f63c9db110a4bdf /drivers/usb
parentd325a1de49d61ee11aca58a529571c91ecea7879 (diff)
downloadop-kernel-dev-844cf8a9d51f1d1e116d0bb18c353a2a94c70e79.zip
op-kernel-dev-844cf8a9d51f1d1e116d0bb18c353a2a94c70e79.tar.gz
usb: gadget: gserial: check if console kthread exists
Check for bad pointer that may result because of kthread_create failure. This check is needed since the gserial setup callback function (gs_console_setup()) is only freeing the info->con_buf in case of kthread_create failure which will result into bad info->console_thread pointer. Without checking info->console_thread pointer validity in the gserial_console_exit() function, before calling kthread_stop(), the rmmod will generate Kernel Oops. Signed-off-by: Bogdan Mirea <Bogdan-Stefan_mirea@mentor.com> Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Diffstat (limited to 'drivers/usb')
-rw-r--r--drivers/usb/gadget/function/u_serial.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/gadget/function/u_serial.c b/drivers/usb/gadget/function/u_serial.c
index 000677c..9b0805f 100644
--- a/drivers/usb/gadget/function/u_serial.c
+++ b/drivers/usb/gadget/function/u_serial.c
@@ -1256,7 +1256,7 @@ static void gserial_console_exit(void)
struct gscons_info *info = &gscons_info;
unregister_console(&gserial_cons);
- if (info->console_thread != NULL)
+ if (!IS_ERR_OR_NULL(info->console_thread))
kthread_stop(info->console_thread);
gs_buf_free(&info->con_buf);
}
OpenPOWER on IntegriCloud