diff options
author | Julia Lawall <julia@diku.dk> | 2009-07-19 17:29:57 +0200 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2009-09-23 06:46:29 -0700 |
commit | 64aebe73152ab3a9f5f426baaf65db632bd72c13 (patch) | |
tree | b96e307aed23b98bd83c1096da8619e0d042849d /drivers/usb/storage/libusual.c | |
parent | 981e60f037631ca725a9790e7b3512de4a60bba8 (diff) | |
download | op-kernel-dev-64aebe73152ab3a9f5f426baaf65db632bd72c13.zip op-kernel-dev-64aebe73152ab3a9f5f426baaf65db632bd72c13.tar.gz |
USB: storage: Drop an unneeded a NULL test
In each case, the NULL test is not necessary because the function is static
and at the only places where it is called, the us argument has already been
dereferenced.
The semantic patch that finds the problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@@
type T;
expression E,E1;
identifier i,fld;
statement S;
@@
- T i = E->fld;
+ T i;
... when != E=E1
when != i
if (E == NULL||...) S
+ i = E->fld;
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: Matthew Dharm <mdharm-usb@one-eyed-alien.net>
Cc: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb/storage/libusual.c')
0 files changed, 0 insertions, 0 deletions