summaryrefslogtreecommitdiffstats
path: root/drivers/usb/misc/usbtest.c
diff options
context:
space:
mode:
authorOrjan Friberg <orjan.friberg@axis.com>2006-08-08 23:31:40 -0700
committerGreg Kroah-Hartman <gregkh@suse.de>2006-08-11 14:06:06 -0700
commitf54fa84dda211f68f65002efa44142207c886c79 (patch)
tree117113e866346afa5737a78ba3ba2085b059aab1 /drivers/usb/misc/usbtest.c
parent2011e9249a252e0655807fbe6841f6cfe6b6c197 (diff)
downloadop-kernel-dev-f54fa84dda211f68f65002efa44142207c886c79.zip
op-kernel-dev-f54fa84dda211f68f65002efa44142207c886c79.tar.gz
USB: usbtest.c: unsigned retval makes ctrl_out return 0 in case of error
In my quest to try and figure out why test 14 (control write) doesn't work with my EZ-USB board, I noticed that sometimes testusb reported no error even though the kernel log complained "byte 0 is 0 not 2" etc. Signed-off-by: David Brownell <dbrownell@users.sourceforge.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb/misc/usbtest.c')
-rw-r--r--drivers/usb/misc/usbtest.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/usb/misc/usbtest.c b/drivers/usb/misc/usbtest.c
index 786e1db..983e104 100644
--- a/drivers/usb/misc/usbtest.c
+++ b/drivers/usb/misc/usbtest.c
@@ -1242,11 +1242,12 @@ done:
static int ctrl_out (struct usbtest_dev *dev,
unsigned count, unsigned length, unsigned vary)
{
- unsigned i, j, len, retval;
+ unsigned i, j, len;
+ int retval;
u8 *buf;
char *what = "?";
struct usb_device *udev;
-
+
if (length < 1 || length > 0xffff || vary >= length)
return -EINVAL;
OpenPOWER on IntegriCloud