summaryrefslogtreecommitdiffstats
path: root/drivers/usb/host
diff options
context:
space:
mode:
authorMathias Nyman <mathias.nyman@linux.intel.com>2017-05-17 18:31:59 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2017-05-18 15:19:41 +0200
commit7bc5d5aff356f3ba16c4d1e9eaf95cc99b7574ab (patch)
tree8ab8eaafc6423ada11e7199261c152b2a96beeac /drivers/usb/host
parent5120a266928a07231d198bb518f6fe73148786a3 (diff)
downloadop-kernel-dev-7bc5d5aff356f3ba16c4d1e9eaf95cc99b7574ab.zip
op-kernel-dev-7bc5d5aff356f3ba16c4d1e9eaf95cc99b7574ab.tar.gz
usb: xhci: trace URB before giving it back instead of after
Don't access any members of a URB after giving it back. URB might be freed by then already. Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/host')
-rw-r--r--drivers/usb/host/xhci-ring.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
index 74bf5c6..507ba77 100644
--- a/drivers/usb/host/xhci-ring.c
+++ b/drivers/usb/host/xhci-ring.c
@@ -641,8 +641,8 @@ static void xhci_giveback_urb_in_irq(struct xhci_hcd *xhci,
xhci_urb_free_priv(urb_priv);
usb_hcd_unlink_urb_from_ep(hcd, urb);
spin_unlock(&xhci->lock);
- usb_hcd_giveback_urb(hcd, urb, status);
trace_xhci_urb_giveback(urb);
+ usb_hcd_giveback_urb(hcd, urb, status);
spin_lock(&xhci->lock);
}
OpenPOWER on IntegriCloud