diff options
| author | Peter Chen <peter.chen@freescale.com> | 2012-01-11 13:39:07 +0800 |
|---|---|---|
| committer | Felipe Balbi <balbi@ti.com> | 2012-01-24 15:43:10 +0200 |
| commit | 118d63f7f84cd400ba537f5d318c035c95c6776d (patch) | |
| tree | 89e609eed01b11cfd0e538cae841986c50a27b1e /drivers/usb/gadget | |
| parent | a37670b1c0f5dee021e451130653936742233457 (diff) | |
| download | op-kernel-dev-118d63f7f84cd400ba537f5d318c035c95c6776d.zip op-kernel-dev-118d63f7f84cd400ba537f5d318c035c95c6776d.tar.gz | |
usb: gadget: fsl_udc: fix the usage of udc->max_ep
The max_ep is the number of endpoint * 2.
But in dtd_complete_irq, it does again * 2, it will deference wrong memory
after scanning max_ep - 1.
The another similar problem is at USB_REQ_SET_FEATURE (the pipe number
should be 0 and max_ep - 1).
Signed-off-by: Peter Chen <peter.chen@freescale.com>
Signed-off-by: Matthieu castet <matthieu.castet@parrot.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Diffstat (limited to 'drivers/usb/gadget')
| -rw-r--r-- | drivers/usb/gadget/fsl_udc_core.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/usb/gadget/fsl_udc_core.c b/drivers/usb/gadget/fsl_udc_core.c index d7ea6c0..b04712f 100644 --- a/drivers/usb/gadget/fsl_udc_core.c +++ b/drivers/usb/gadget/fsl_udc_core.c @@ -1430,7 +1430,7 @@ static void setup_received_irq(struct fsl_udc *udc, int pipe = get_pipe_by_windex(wIndex); struct fsl_ep *ep; - if (wValue != 0 || wLength != 0 || pipe > udc->max_ep) + if (wValue != 0 || wLength != 0 || pipe >= udc->max_ep) break; ep = get_ep_by_pipe(udc, pipe); @@ -1673,7 +1673,7 @@ static void dtd_complete_irq(struct fsl_udc *udc) if (!bit_pos) return; - for (i = 0; i < udc->max_ep * 2; i++) { + for (i = 0; i < udc->max_ep; i++) { ep_num = i >> 1; direction = i % 2; |
