diff options
| author | Milan Svoboda <msvoboda@ra.rockwell.com> | 2006-08-08 22:14:43 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2006-09-27 11:58:54 -0700 |
| commit | a94da8971e836f32315f8832b0bf3e88bee9efae (patch) | |
| tree | 6c9fe746a803f26b5c853c7cbb646a867b3f13a4 /drivers/usb/gadget | |
| parent | e22fc27c87b41bda1b0daf8436224b0f79853482 (diff) | |
| download | op-kernel-dev-a94da8971e836f32315f8832b0bf3e88bee9efae.zip op-kernel-dev-a94da8971e836f32315f8832b0bf3e88bee9efae.tar.gz | |
USB gadget: gadgetfs dont try to lock before free
I spotted this during my tests with -rt on arm. The -rt patch contains
some better tools
to diagnose problems with locks and some other things...
Original code tries to take semaphore in BUG_ON and then free the memory
with this semaphore.
Signed-off-by: Milan Svoboda <msvoboda@ra.rockwell.com>
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb/gadget')
| -rw-r--r-- | drivers/usb/gadget/inode.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/usb/gadget/inode.c b/drivers/usb/gadget/inode.c index ed9b404..a38b6af 100644 --- a/drivers/usb/gadget/inode.c +++ b/drivers/usb/gadget/inode.c @@ -223,7 +223,6 @@ static void put_ep (struct ep_data *data) /* needs no more cleanup */ BUG_ON (!list_empty (&data->epfiles)); BUG_ON (waitqueue_active (&data->wait)); - BUG_ON (down_trylock (&data->lock) != 0); kfree (data); } |
