summaryrefslogtreecommitdiffstats
path: root/drivers/usb/class
diff options
context:
space:
mode:
authorJulia Lawall <julia@diku.dk>2011-12-23 18:39:28 +0100
committerGreg Kroah-Hartman <gregkh@suse.de>2012-01-04 15:52:42 -0800
commit5632c827cbd3617613530ba0e99344192d0a31ca (patch)
tree374c8744a0280685434e6ecf1282df8834916d7e /drivers/usb/class
parent30a0dee7806d099c709603e65aa08be0363ea49d (diff)
downloadop-kernel-dev-5632c827cbd3617613530ba0e99344192d0a31ca.zip
op-kernel-dev-5632c827cbd3617613530ba0e99344192d0a31ca.tar.gz
drivers/usb/dwc3/dwc3-pci.c: introduce missing kfree
Glue needs to be freed on exiting the function in an error case. Furthermore, pci, which is the first argument to the probe function should not be freed before leaveing the function, as it is reused at the call site. So the free of pci is changed to free glue instead. A simplified version of the semantic match that finds the problem is as follows: (http://coccinelle.lip6.fr) // <smpl> @r exists@ local idexpression x; statement S; identifier f1; position p1,p2; expression *ptr != NULL; @@ x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...); ... if (x == NULL) S <... when != x when != if (...) { <+...x...+> } x->f1 ...> ( return \(0\|<+...x...+>\|ptr\); | return@p2 ...; ) @script:python@ p1 << r.p1; p2 << r.p2; @@ print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line) // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb/class')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud