summaryrefslogtreecommitdiffstats
path: root/drivers/tty
diff options
context:
space:
mode:
authorStefan Potyra <Stefan.Potyra@elektrobit.com>2018-04-24 18:03:47 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2018-04-25 14:56:12 +0200
commite76785d092ab8356d24996754f0ff1917021fcb6 (patch)
tree185bd4d2e19b1ea151c9786d5b9edac8ef277a11 /drivers/tty
parent2468b3e4aa7b2a45443c43fced850965ee8118bd (diff)
downloadop-kernel-dev-e76785d092ab8356d24996754f0ff1917021fcb6.zip
op-kernel-dev-e76785d092ab8356d24996754f0ff1917021fcb6.tar.gz
sc16is7xx: Check for an error when the clock is enabled.
When the clock is enabled, check if there is an error. Otherwise clk_get_rate() can be called without enabled clock. Found by Linux Driver Verification project (linuxtesting.org). Fixes: 0814e8d5da2b ("sc16is7xx: enable the clock") Signed-off-by: Stefan Potyra <Stefan.Potyra@elektrobit.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/tty')
-rw-r--r--drivers/tty/serial/sc16is7xx.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
index 65792a3..243c960 100644
--- a/drivers/tty/serial/sc16is7xx.c
+++ b/drivers/tty/serial/sc16is7xx.c
@@ -1168,7 +1168,10 @@ static int sc16is7xx_probe(struct device *dev,
else
return PTR_ERR(s->clk);
} else {
- clk_prepare_enable(s->clk);
+ ret = clk_prepare_enable(s->clk);
+ if (ret)
+ return ret;
+
freq = clk_get_rate(s->clk);
}
OpenPOWER on IntegriCloud