summaryrefslogtreecommitdiffstats
path: root/drivers/tty/tty_audit.c
diff options
context:
space:
mode:
authorEric Paris <eparis@redhat.com>2013-04-30 10:46:46 -0400
committerEric Paris <eparis@redhat.com>2013-04-30 15:31:28 -0400
commitbee0a224e791cccbc7ecd7faf2d5932942668976 (patch)
tree2ce6e13d41ce4c6b30e68ca18700d695ca950206 /drivers/tty/tty_audit.c
parent2ce88dd04276839002a3b31161090d282316610b (diff)
downloadop-kernel-dev-bee0a224e791cccbc7ecd7faf2d5932942668976.zip
op-kernel-dev-bee0a224e791cccbc7ecd7faf2d5932942668976.tar.gz
audit: do not needlessly take a lock in tty_audit_exit
We were doing spin_lock_irq and spin_unlock_irq. This is STOOPID. If we were in interupt context we were already screwed and called panic() in do_exit(). So the irq stuff is useless. Also, these values can only be changed by receiving a netlink message from current. Since we are in do_exit() clearly we aren't in the syscall sending the netlink message to change these values. Thus, just read them and go with it. Signed-off-by: Eric Paris <eparis@redhat.com>
Diffstat (limited to 'drivers/tty/tty_audit.c')
-rw-r--r--drivers/tty/tty_audit.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/tty/tty_audit.c b/drivers/tty/tty_audit.c
index a03a751..a4fdce7 100644
--- a/drivers/tty/tty_audit.c
+++ b/drivers/tty/tty_audit.c
@@ -111,12 +111,9 @@ static void tty_audit_buf_push(struct tty_audit_buf *buf)
void tty_audit_exit(void)
{
struct tty_audit_buf *buf;
- unsigned long flags;
- spin_lock_irqsave(&current->sighand->siglock, flags);
buf = current->signal->tty_audit_buf;
current->signal->tty_audit_buf = NULL;
- spin_unlock_irqrestore(&current->sighand->siglock, flags);
if (!buf)
return;
OpenPOWER on IntegriCloud