diff options
| author | Wei Yongjun <weiyongjun1@huawei.com> | 2018-03-22 02:25:07 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-03-22 18:33:44 +0100 |
| commit | 7693b331d033ecda61097007330d3e7461ff7f27 (patch) | |
| tree | acf56be46d8198fa780ad1774cd14db518749b0b /drivers/tty/serial | |
| parent | 4958134df54c2c84e9c22ea042761d439164d26e (diff) | |
| download | op-kernel-dev-7693b331d033ecda61097007330d3e7461ff7f27.zip op-kernel-dev-7693b331d033ecda61097007330d3e7461ff7f27.tar.gz | |
tty: serial: msm_geni_serial: Fix return value check in qcom_geni_serial_probe()
In case of error, the function platform_get_resource() returns NULL
pointer not ERR_PTR(). The IS_ERR() test in the return value check
should be replaced with NULL test.
Fixes: c4f528795d1a ("tty: serial: msm_geni_serial: Add serial driver support for GENI based QUP")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/tty/serial')
| -rw-r--r-- | drivers/tty/serial/qcom_geni_serial.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c index 1442777..65ff669 100644 --- a/drivers/tty/serial/qcom_geni_serial.c +++ b/drivers/tty/serial/qcom_geni_serial.c @@ -1053,8 +1053,8 @@ static int qcom_geni_serial_probe(struct platform_device *pdev) } res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (IS_ERR(res)) - return PTR_ERR(res); + if (!res) + return -EINVAL; uport->mapbase = res->start; port->tx_fifo_depth = DEF_FIFO_DEPTH_WORDS; |
