summaryrefslogtreecommitdiffstats
path: root/drivers/tty/ipwireless
diff options
context:
space:
mode:
authorJiri Slaby <jslaby@suse.cz>2012-04-02 13:54:31 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2012-04-09 11:30:39 -0700
commitde3a60a3436ebfd780ced830cd09880ea9c45957 (patch)
tree80f376129cc276547dcbbfd08903e612e36e61e1 /drivers/tty/ipwireless
parentdaea440215ae86bf9fdfe82420710ae749eb73c7 (diff)
downloadop-kernel-dev-de3a60a3436ebfd780ced830cd09880ea9c45957.zip
op-kernel-dev-de3a60a3436ebfd780ced830cd09880ea9c45957.tar.gz
TTY: ipwireless, use synchronous hangup
Do not touch internal workqueue. Call tty_vhangup instead. Note that finished hangup does not necessarily mean that all processes are dead. Especially when the tty is a console. The code assumes that right now. Signed-off-by: Jiri Slaby <jslaby@suse.cz> Cc: Jiri Kosina <jkosina@suse.cz> Acked-by: David Sterba <dsterba@suse.cz> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/tty/ipwireless')
-rw-r--r--drivers/tty/ipwireless/tty.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/tty/ipwireless/tty.c b/drivers/tty/ipwireless/tty.c
index 4daf962..e539621 100644
--- a/drivers/tty/ipwireless/tty.c
+++ b/drivers/tty/ipwireless/tty.c
@@ -565,11 +565,11 @@ void ipwireless_tty_free(struct ipw_tty *tty)
ttyj->closing = 1;
if (ttyj->linux_tty != NULL) {
mutex_unlock(&ttyj->ipw_tty_mutex);
- tty_hangup(ttyj->linux_tty);
- /* Wait till the tty_hangup has completed */
- flush_work_sync(&ttyj->linux_tty->hangup_work);
+ tty_vhangup(ttyj->linux_tty);
/* FIXME: Exactly how is the tty object locked here
against a parallel ioctl etc */
+ /* FIXME2: hangup does not mean all processes
+ * are gone */
mutex_lock(&ttyj->ipw_tty_mutex);
}
while (ttyj->open_count)
OpenPOWER on IntegriCloud