summaryrefslogtreecommitdiffstats
path: root/drivers/target
diff options
context:
space:
mode:
authorRoland Dreier <roland@purestorage.com>2012-10-31 09:16:44 -0700
committerNicholas Bellinger <nab@linux-iscsi.org>2012-11-01 00:38:31 -0700
commit0d0f9dfb31e0a6c92063e235417b42df185b3275 (patch)
tree834a22aa519cb6b9cd28de32b750700a92c923c1 /drivers/target
parentdea5f0998aa82bdeca260b87c653db11e91329b2 (diff)
downloadop-kernel-dev-0d0f9dfb31e0a6c92063e235417b42df185b3275.zip
op-kernel-dev-0d0f9dfb31e0a6c92063e235417b42df185b3275.tar.gz
target: Don't return success from module_init() if setup fails
If the call to core_dev_release_virtual_lun0() fails, then nothing sets ret to anything other than 0, so even though everything is torn down and freed, target_core_init_configfs() will seem to succeed and the module will be loaded. Fix this by passing the return value on up the chain. Signed-off-by: Roland Dreier <roland@purestorage.com> Cc: stable@vger.kernel.org Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Diffstat (limited to 'drivers/target')
-rw-r--r--drivers/target/target_core_configfs.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c
index 015f5be..c123327 100644
--- a/drivers/target/target_core_configfs.c
+++ b/drivers/target/target_core_configfs.c
@@ -3206,7 +3206,8 @@ static int __init target_core_init_configfs(void)
if (ret < 0)
goto out;
- if (core_dev_setup_virtual_lun0() < 0)
+ ret = core_dev_setup_virtual_lun0();
+ if (ret < 0)
goto out;
return 0;
OpenPOWER on IntegriCloud