diff options
| author | Nicholas Bellinger <nab@linux-iscsi.org> | 2012-01-16 17:11:54 -0800 |
|---|---|---|
| committer | Nicholas Bellinger <nab@linux-iscsi.org> | 2012-01-18 08:35:57 +0000 |
| commit | cd931ee62fd0258fc85c76a7c5499fe85e0f3436 (patch) | |
| tree | 3e98ce1d1fc20b0782dee6eea01e6db295d12503 /drivers/target | |
| parent | c1ce4bd56f2846de55043374598fd929ad3b711b (diff) | |
| download | op-kernel-dev-cd931ee62fd0258fc85c76a7c5499fe85e0f3436.zip op-kernel-dev-cd931ee62fd0258fc85c76a7c5499fe85e0f3436.tar.gz | |
iscsi-target: Fix double list_add with iscsit_alloc_buffs reject
This patch fixes a bug where the iscsit_add_reject_from_cmd() call
from a failure to iscsit_alloc_buffs() was incorrectly passing
add_to_conn=1 and causing a double list_add after iscsi_cmd->i_list
had already been added in iscsit_handle_scsi_cmd().
Cc: <stable@vger.kernel.org>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Diffstat (limited to 'drivers/target')
| -rw-r--r-- | drivers/target/iscsi/iscsi_target.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c index ac44af1..6e070e0 100644 --- a/drivers/target/iscsi/iscsi_target.c +++ b/drivers/target/iscsi/iscsi_target.c @@ -1061,7 +1061,7 @@ attach_cmd: if (ret < 0) return iscsit_add_reject_from_cmd( ISCSI_REASON_BOOKMARK_NO_RESOURCES, - 1, 1, buf, cmd); + 1, 0, buf, cmd); /* * Check the CmdSN against ExpCmdSN/MaxCmdSN here if * the Immediate Bit is not set, and no Immediate |
