summaryrefslogtreecommitdiffstats
path: root/drivers/target/iscsi
diff options
context:
space:
mode:
authorNicholas Bellinger <nab@linux-iscsi.org>2013-07-06 16:48:55 -0700
committerNicholas Bellinger <nab@linux-iscsi.org>2013-07-07 18:36:50 -0700
commit37b32c6faf0e0e40c65c1014df7527ececdd3f9a (patch)
tree99a74c2eb21bb561209ce202613a820544d24467 /drivers/target/iscsi
parent0fbfc46fb0b2f543a8b539e94c6c293ebc0b05a6 (diff)
downloadop-kernel-dev-37b32c6faf0e0e40c65c1014df7527ececdd3f9a.zip
op-kernel-dev-37b32c6faf0e0e40c65c1014df7527ececdd3f9a.tar.gz
iscsi-target: Fix tfc_tpg_auth_cit configfs length overflow
This patch fixes another potential buffer overflow while processing iscsi_node_auth input for configfs attributes in v3.11 for-next TPG tfc_tpg_auth_cit context. Reported-by: Joern Engel <joern@logfs.org> Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Diffstat (limited to 'drivers/target/iscsi')
-rw-r--r--drivers/target/iscsi/iscsi_target_configfs.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/target/iscsi/iscsi_target_configfs.c b/drivers/target/iscsi/iscsi_target_configfs.c
index 88bc805..b41d478 100644
--- a/drivers/target/iscsi/iscsi_target_configfs.c
+++ b/drivers/target/iscsi/iscsi_target_configfs.c
@@ -1081,7 +1081,7 @@ static ssize_t __iscsi_##prefix##_store_##name( \
if (!capable(CAP_SYS_ADMIN)) \
return -EPERM; \
\
- snprintf(auth->name, PAGE_SIZE, "%s", page); \
+ snprintf(auth->name, sizeof(auth->name), "%s", page); \
if (!(strncmp("NULL", auth->name, 4))) \
auth->naf_flags &= ~flags; \
else \
OpenPOWER on IntegriCloud