diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2015-05-19 15:25:24 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2015-05-31 11:47:56 +0900 |
| commit | 46d74c38eba22bee848c205e8a98fc4b6b53a081 (patch) | |
| tree | cdaae35f30a26259a010b8f5b9aad75c21d78791 /drivers/staging | |
| parent | 24768169c7929e706150ab34731394e42b5215f3 (diff) | |
| download | op-kernel-dev-46d74c38eba22bee848c205e8a98fc4b6b53a081.zip op-kernel-dev-46d74c38eba22bee848c205e8a98fc4b6b53a081.tar.gz | |
staging: slicoss: restore IRQs correctly after slic_cmdq_reset()
We can't save two different values in "flags" so it means that IRQs are
not enabled properly at the end of this function. This isn't a problem
in the current code because it's always called with IRQs disabled so we
don't want to enable them at the end.
This bug is old but it's thanks to David Matlack's recent cleanups that
Smatch can detect it.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: David Matlack <dmatlack@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging')
| -rw-r--r-- | drivers/staging/slicoss/slicoss.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c index 5f34ebbf..a609f3e 100644 --- a/drivers/staging/slicoss/slicoss.c +++ b/drivers/staging/slicoss/slicoss.c @@ -1392,7 +1392,7 @@ static void slic_cmdq_reset(struct adapter *adapter) unsigned long flags; spin_lock_irqsave(&adapter->cmdq_free.lock, flags); - spin_lock_irqsave(&adapter->cmdq_done.lock, flags); + spin_lock(&adapter->cmdq_done.lock); outstanding = adapter->cmdq_all.count - adapter->cmdq_done.count; outstanding -= adapter->cmdq_free.count; hcmd = adapter->cmdq_all.head; @@ -1423,7 +1423,7 @@ static void slic_cmdq_reset(struct adapter *adapter) "free_count %d != all count %d\n", adapter->cmdq_free.count, adapter->cmdq_all.count); } - spin_unlock_irqrestore(&adapter->cmdq_done.lock, flags); + spin_unlock(&adapter->cmdq_done.lock); spin_unlock_irqrestore(&adapter->cmdq_free.lock, flags); } |
