summaryrefslogtreecommitdiffstats
path: root/drivers/staging
diff options
context:
space:
mode:
authorChristian Gromm <christian.gromm@microchip.com>2015-12-22 10:53:00 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2016-02-07 17:34:58 -0800
commit0ccaa6de8edb0053efd4dcc49e8f053bf5ff7595 (patch)
tree3791bedd0cc3b7f09a261d94fcddd9051ea4ee6f /drivers/staging
parent61f6bfcbaee6b49f3147ba5a3fd8d9803272b433 (diff)
downloadop-kernel-dev-0ccaa6de8edb0053efd4dcc49e8f053bf5ff7595.zip
op-kernel-dev-0ccaa6de8edb0053efd4dcc49e8f053bf5ff7595.tar.gz
staging: most: remove redundant call to wake_up_interruptible
This patch prevents the cdev module from rousing the channel wait queue in case the channel is about to be closed. It is safe to do so, because the application can not be waiting within read or write and at the same time be calling close. Signed-off-by: Christian Gromm <christian.gromm@microchip.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging')
-rw-r--r--drivers/staging/most/aim-cdev/cdev.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/staging/most/aim-cdev/cdev.c b/drivers/staging/most/aim-cdev/cdev.c
index 0141293..fd2ac89 100644
--- a/drivers/staging/most/aim-cdev/cdev.c
+++ b/drivers/staging/most/aim-cdev/cdev.c
@@ -127,7 +127,6 @@ static int aim_close(struct inode *inode, struct file *filp)
kfifo_free(&channel->fifo);
list_del(&channel->list);
ida_simple_remove(&minor_id, MINOR(channel->devno));
- wake_up_interruptible(&channel->wq);
kfree(channel);
return 0;
}
@@ -139,7 +138,6 @@ static int aim_close(struct inode *inode, struct file *filp)
most_put_mbo(channel->stacked_mbo);
ret = most_stop_channel(channel->iface, channel->channel_id, &cdev_aim);
atomic_dec(&channel->access_ref);
- wake_up_interruptible(&channel->wq);
return ret;
}
OpenPOWER on IntegriCloud